Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user names behave according to SQL identifiers rules [CORE4811] #5109

Closed
firebird-automations opened this issue May 23, 2015 · 8 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @AlexPeshkoff

Relate to CORE4820
Relate to CORE3717
Is related to CORE4864

According to the results of the discussion in firebird developers list it was decided to make user names (logins) to behave like the rest of SQL identifiers - particularly, quoted identifier is case-sensitive. When passed in DPB also as case-sensitive are treated identifiers, containing non-ascii (code > 0x7F) symbols, because in other places such names are always quoted and therefore case-sensitive.

Commits: 8c767ad 0f430b4 3fc04a9 77f6054 8d645cd 1b6632a FirebirdSQL/fbt-repository@815e42f FirebirdSQL/fbt-repository@12e519c FirebirdSQL/fbt-repository@5a28f25 FirebirdSQL/fbt-repository@081022c FirebirdSQL/fbt-repository@e5d7ac4 FirebirdSQL/fbt-repository@fd57bb9 FirebirdSQL/fbt-repository@cb62ece

====== Test Details ======

Implemented only simplest case: both user login and role contains only ASCII characters, though with mixed case.
More complex testing will be implemented after FB will allow to use non-ascii logins - currently get 'gsec error'.
Wait for reply from Alex, letter 11-jun-2015 22:01 (subj: "About 'fixed CORE4760'...")

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Improvement cause some minor incompatibilities with previous firebird versions, first of all in CREATE DATABASE statement. Historically ISQL accepted USER's parameter as quoted string. Currently one can use for a traditional latin-name user with all upper letters any form of SYSDBA / sysdba / 'SYSDBA' / "SYSDBA", but an attempt to use 'sysdba' or "sysdba" remaining syntactically correct will cause an invalid login or password error.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 Beta 2 [ 10586 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue relate to CORE4820 [ CORE4820 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Done with caveats

Test Details: Implemented only simplest case: both user login and role contains only ASCII characters, though with mixed case.
More complex testing will be implemented after FB will allow to use non-ascii logins - currently get 'gsec error'.
Wait for reply from Alex, letter 11-jun-2015 22:01 (subj: "About 'fixed CORE4760'...")

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue relate to CORE3717 [ CORE3717 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue is related to CORE4864 [ CORE4864 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment