Transactions with isc_tpb_autocommit can hang the server [CORE4840] #5136

firebird-automations · 2015-06-14T11:58:29Z

I was testing the pull request of Maxim for Jaybird. A test that creates a stored procedure and adds a comment on that stored procedure in a transaction with isc_tpb_autocommit hangs the entire Firebird 3 server when executing the statement that adds the comment. The Firebird 3 server stops responding entirely.

The test that reproduce this is (see also attachment):

private static final String CREATE\_PROCEDURE =
        "CREATE PROCEDURE testproc1 \(IN1 INTEGER, IN2 FLOAT\)" \+
        "RETURNS \(OUT1 VARCHAR\(20\), " \+
        "  OUT2 DOUBLE PRECISION, OUT3 INTEGER\) AS " \+
        " DECLARE VARIABLE X INTEGER;" \+
        "BEGIN" \+
        " OUT1 = 'Out String';" \+
        " OUT2 = 45;" \+
        " OUT3 = IN1;" \+
        "END";

private static final String ADD\_COMMENT = "COMMENT ON PROCEDURE testproc1 IS 'Test description'";

@Test
public void iscTpbAutocommit\_hangsServer\(\) throws SQLException \{
    try \(FbDatabase db = createDatabaseConnection\(\)\) \{
        db\.attach\(\);

        TransactionParameterBuffer tpb = new TransactionParameterBufferImpl\(\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_read\_committed\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_rec\_version\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_write\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_wait\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_autocommit\);
        FbTransaction transaction = db\.startTransaction\(tpb\);
        try \{
            FbStatement statement = db\.createStatement\(transaction\);
            statement\.prepare\(CREATE\_PROCEDURE\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
            statement\.prepare\(ADD\_COMMENT\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
        \} finally \{
            transaction\.commit\(\);
        \}
    \}
\}

The same test runs fine against Firebird 2.5.4.

The firebird.log contains:

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)
internal Firebird consistency check (wrong record version (185), file: vio.cpp line: 3740)

Commits: 302cd6b FirebirdSQL/fbt-repository@cfcc21e

====== Test Details ======

Confirmed:
1. Crash on LI-V3.0.0.32173, WI-V3.0.0.32239 Rev: 62703 (nightly update)
2. Normal work on LI-V3.0.0.32239 Rev: 62705

The text was updated successfully, but these errors were encountered:

firebird-automations · 2015-06-14T11:58:56Z

Modified by: @mrotteveel

Attachment: TpbAutocommitTest.java [ 12766 ]

firebird-automations · 2015-06-14T12:00:04Z

Modified by: @mrotteveel

description: I was testing the pull request of Maxim for Jaybird. A test that creates a stored procedure and adds a comment on that stored procedure in a transaction with isc_tpb_autocommit hangs the entire Firebird 3 server. The Firebird 3 server stops responding entirely.

The test is (see also attachment):

private static final String CREATE\_PROCEDURE =
        "CREATE PROCEDURE testproc1 \(IN1 INTEGER, IN2 FLOAT\)" \+
        "RETURNS \(OUT1 VARCHAR\(20\), " \+
        "  OUT2 DOUBLE PRECISION, OUT3 INTEGER\) AS " \+
        " DECLARE VARIABLE X INTEGER;" \+
        "BEGIN" \+
        " OUT1 = 'Out String';" \+
        " OUT2 = 45;" \+
        " OUT3 = IN1;" \+
        "END";

private static final String ADD\_COMMENT = "COMMENT ON PROCEDURE testproc1 IS 'Test description'";

@Test
public void iscTpbAutocommit\_hangsServer\(\) throws SQLException \{
    try \(FbDatabase db = createDatabaseConnection\(\)\) \{
        db\.attach\(\);

        TransactionParameterBuffer tpb = new TransactionParameterBufferImpl\(\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_read\_committed\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_rec\_version\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_write\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_wait\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_autocommit\);
        FbTransaction transaction = db\.startTransaction\(tpb\);
        try \{
            FbStatement statement = db\.createStatement\(transaction\);
            statement\.prepare\(CREATE\_PROCEDURE\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
            statement\.prepare\(ADD\_COMMENT\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
        \} finally \{
            transaction\.commit\(\);
        \}
    \}
\}

The same test runs fine against Firebird 2.5.4.

The firebird.log contains:

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)
internal Firebird consistency check (wrong record version (185), file: vio.cpp line: 3740)

=>

I was testing the pull request of Maxim for Jaybird. A test that creates a stored procedure and adds a comment on that stored procedure in a transaction with isc_tpb_autocommit hangs the entire Firebird 3 server. The Firebird 3 server stops responding entirely.

The test that reproduce this is (see also attachment):

private static final String CREATE\_PROCEDURE =
        "CREATE PROCEDURE testproc1 \(IN1 INTEGER, IN2 FLOAT\)" \+
        "RETURNS \(OUT1 VARCHAR\(20\), " \+
        "  OUT2 DOUBLE PRECISION, OUT3 INTEGER\) AS " \+
        " DECLARE VARIABLE X INTEGER;" \+
        "BEGIN" \+
        " OUT1 = 'Out String';" \+
        " OUT2 = 45;" \+
        " OUT3 = IN1;" \+
        "END";

private static final String ADD\_COMMENT = "COMMENT ON PROCEDURE testproc1 IS 'Test description'";

@Test
public void iscTpbAutocommit\_hangsServer\(\) throws SQLException \{
    try \(FbDatabase db = createDatabaseConnection\(\)\) \{
        db\.attach\(\);

        TransactionParameterBuffer tpb = new TransactionParameterBufferImpl\(\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_read\_committed\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_rec\_version\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_write\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_wait\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_autocommit\);
        FbTransaction transaction = db\.startTransaction\(tpb\);
        try \{
            FbStatement statement = db\.createStatement\(transaction\);
            statement\.prepare\(CREATE\_PROCEDURE\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
            statement\.prepare\(ADD\_COMMENT\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
        \} finally \{
            transaction\.commit\(\);
        \}
    \}
\}

The same test runs fine against Firebird 2.5.4.

The firebird.log contains:

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)
internal Firebird consistency check (wrong record version (185), file: vio.cpp line: 3740)

firebird-automations · 2015-06-14T12:01:54Z

Modified by: @mrotteveel

description: I was testing the pull request of Maxim for Jaybird. A test that creates a stored procedure and adds a comment on that stored procedure in a transaction with isc_tpb_autocommit hangs the entire Firebird 3 server. The Firebird 3 server stops responding entirely.

The test that reproduce this is (see also attachment):

private static final String CREATE\_PROCEDURE =
        "CREATE PROCEDURE testproc1 \(IN1 INTEGER, IN2 FLOAT\)" \+
        "RETURNS \(OUT1 VARCHAR\(20\), " \+
        "  OUT2 DOUBLE PRECISION, OUT3 INTEGER\) AS " \+
        " DECLARE VARIABLE X INTEGER;" \+
        "BEGIN" \+
        " OUT1 = 'Out String';" \+
        " OUT2 = 45;" \+
        " OUT3 = IN1;" \+
        "END";

private static final String ADD\_COMMENT = "COMMENT ON PROCEDURE testproc1 IS 'Test description'";

@Test
public void iscTpbAutocommit\_hangsServer\(\) throws SQLException \{
    try \(FbDatabase db = createDatabaseConnection\(\)\) \{
        db\.attach\(\);

        TransactionParameterBuffer tpb = new TransactionParameterBufferImpl\(\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_read\_committed\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_rec\_version\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_write\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_wait\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_autocommit\);
        FbTransaction transaction = db\.startTransaction\(tpb\);
        try \{
            FbStatement statement = db\.createStatement\(transaction\);
            statement\.prepare\(CREATE\_PROCEDURE\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
            statement\.prepare\(ADD\_COMMENT\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
        \} finally \{
            transaction\.commit\(\);
        \}
    \}
\}

The same test runs fine against Firebird 2.5.4.

The firebird.log contains:

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)
internal Firebird consistency check (wrong record version (185), file: vio.cpp line: 3740)

=>

I was testing the pull request of Maxim for Jaybird. A test that creates a stored procedure and adds a comment on that stored procedure in a transaction with isc_tpb_autocommit hangs the entire Firebird 3 server when executing the statement that adds the comment. The Firebird 3 server stops responding entirely.

The test that reproduce this is (see also attachment):

private static final String CREATE\_PROCEDURE =
        "CREATE PROCEDURE testproc1 \(IN1 INTEGER, IN2 FLOAT\)" \+
        "RETURNS \(OUT1 VARCHAR\(20\), " \+
        "  OUT2 DOUBLE PRECISION, OUT3 INTEGER\) AS " \+
        " DECLARE VARIABLE X INTEGER;" \+
        "BEGIN" \+
        " OUT1 = 'Out String';" \+
        " OUT2 = 45;" \+
        " OUT3 = IN1;" \+
        "END";

private static final String ADD\_COMMENT = "COMMENT ON PROCEDURE testproc1 IS 'Test description'";

@Test
public void iscTpbAutocommit\_hangsServer\(\) throws SQLException \{
    try \(FbDatabase db = createDatabaseConnection\(\)\) \{
        db\.attach\(\);

        TransactionParameterBuffer tpb = new TransactionParameterBufferImpl\(\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_read\_committed\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_rec\_version\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_write\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_wait\);
        tpb\.addArgument\(ISCConstants\.isc\_tpb\_autocommit\);
        FbTransaction transaction = db\.startTransaction\(tpb\);
        try \{
            FbStatement statement = db\.createStatement\(transaction\);
            statement\.prepare\(CREATE\_PROCEDURE\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
            statement\.prepare\(ADD\_COMMENT\);
            statement\.execute\(RowValue\.EMPTY\_ROW\_VALUE\);
        \} finally \{
            transaction\.commit\(\);
        \}
    \}
\}

The same test runs fine against Firebird 2.5.4.

The firebird.log contains:

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)

RAMONA Sun Jun 14 10:56:16 2015
Database: D:\DEVELOPMENT\PROJECT\JAYBIRD\JAYBIRD\FBTEST.FDB
internal Firebird consistency check (Too many savepoints (287), file: tra.cpp line: 2470)
internal Firebird consistency check (wrong record version (185), file: vio.cpp line: 3740)

firebird-automations · 2015-07-05T12:15:26Z

Modified by: @dyemanov

Fix Version: 3.0 RC 1 [ 10584 ]

firebird-automations · 2015-10-27T11:35:54Z

Modified by: @dyemanov

Fix Version: 3.0.0 [ 10048 ]

Fix Version: 3.0 RC 1 [ 10584 ] =>

firebird-automations · 2015-10-29T22:09:01Z

Commented by: @mrotteveel

BTW: This looks a lot like CORE3825

firebird-automations · 2015-12-19T09:11:33Z

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

firebird-automations · 2015-12-19T12:43:49Z

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

firebird-automations · 2015-12-20T01:05:54Z

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

Test Details: Confirmed:
1. Crash on LI-V3.0.0.32173, WI-V3.0.0.32239
2. Normal work on LI-V3.0.0.32239 Rev: 62705

firebird-automations · 2015-12-20T01:06:01Z

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

firebird-automations · 2015-12-20T01:09:04Z

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

Test Details: Confirmed:
1. Crash on LI-V3.0.0.32173, WI-V3.0.0.32239
2. Normal work on LI-V3.0.0.32239 Rev: 62705

=>

Confirmed:
1. Crash on LI-V3.0.0.32173, WI-V3.0.0.32239 Rev: 62703 (nightly update)
2. Normal work on LI-V3.0.0.32239 Rev: 62705

firebird-automations closed this as completed Dec 20, 2015

firebird-automations added affect-version: 3.0 Beta 2 fix-version: 3.0 RC2 resolution: fixed priority: blocker component: engine type: bug qa: done successfully labels Apr 25, 2021

firebird-automations assigned dyemanov Apr 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transactions with isc_tpb_autocommit can hang the server [CORE4840] #5136

Transactions with isc_tpb_autocommit can hang the server [CORE4840] #5136

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jul 5, 2015

firebird-automations commented Oct 27, 2015

firebird-automations commented Oct 29, 2015

firebird-automations commented Dec 19, 2015

firebird-automations commented Dec 19, 2015

firebird-automations commented Dec 20, 2015

firebird-automations commented Dec 20, 2015

firebird-automations commented Dec 20, 2015

Transactions with isc_tpb_autocommit can hang the server [CORE4840] #5136

Transactions with isc_tpb_autocommit can hang the server [CORE4840] #5136

Comments

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jun 14, 2015

firebird-automations commented Jul 5, 2015

firebird-automations commented Oct 27, 2015

firebird-automations commented Oct 29, 2015

firebird-automations commented Dec 19, 2015

firebird-automations commented Dec 19, 2015

firebird-automations commented Dec 20, 2015

firebird-automations commented Dec 20, 2015

firebird-automations commented Dec 20, 2015