New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISQL input command (or -i option) reads large (> 64K) lines incorrectly [CORE4882] #5176
Comments
Modified by: @asfernandesassignee: Adriano dos Santos Fernandes [ asfernandes ] |
Modified by: @asfernandesstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 3.0 RC 1 [ 10584 ] |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Done successfully |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Closed [ 6 ] |
Commented by: @pavel-zotov I've found that following sample still can`t be compiled: set term ^; create or alter procedure sp_test2 as Both on 32 and 64 bit (build # 3.0.0.32008) following error is produced:Expected end of statement, encountered EOFPacked script please see in attach. PS. Is this somehow relate to this ticket or to recently fixed CORE4890 ? or this completely new bug ? |
Modified by: @pavel-zotovAttachment: comment-100mb.sql.zip [ 12799 ] |
Commented by: @pavel-zotov It seems that maximal size of single SQL statement that can be successfully compiled is 10 590 614 bytes. AFAIR, hard-coded limit is 10 Mb, i.e. 10 485 760. How this limit can be exeeded (see attahed "sql-command-with-huge-comment-about-compiler-implementation-limit.zip", file huge-comment-max-can-be-compiled-ok.sql with size 10590614) ? |
Modified by: @pavel-zotovAttachment: sql-command-with-huge-comment-about-compiler-implementation-limit.zip [ 12800 ] |
Commented by: @dyemanov The 10MB limit does not raise any error, it just truncates the SQL string. So the error message could really be different, depending on what grammar rule is incomplete. If you don't like that, we may raise "implementation limit exceeded" instead. |
Commented by: @pavel-zotov IMHO compiler should produce only one message ("implementation limit exceeded") in any case, regardless of input string length. |
Submitted by: @asfernandes
Attachments:
comment-100mb.sql.zip
sql-command-with-huge-comment-about-compiler-implementation-limit.zip
ISQL breaks large lines (possibly inside a string) in multiple lines.
Commits: 442388d FirebirdSQL/fbt-repository@660dd72
The text was updated successfully, but these errors were encountered: