Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IO operations with nbackup backup file aligned at page size boundary [CORE4939] #5230

Closed
firebird-automations opened this issue Sep 20, 2015 · 4 comments
Closed

Make IO operations with nbackup backup file aligned at page size boundary [CORE4939] #5230

firebird-automations opened this issue Sep 20, 2015 · 4 comments
Assignees
@hvlad
Labels
component: nbackup fix-version: 3.0 RC1 priority: major qa: cannot be tested type: improvement

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

Currently nbackup backup file contains backup header followed by set of <page_number, page_contents> pairs.
Since ODS 12 we store page number at page header. Therefore there is no need to store page_number before
page contents in backup file. Such change makes IO aligned at page size boundary which should be more efficient
and opens possibility to work with async\unbuffered IO in the future.

Commits: 09cc613 FirebirdSQL/fbt-repository@55cbb4e
@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 3.0 RC 1 [ 10584 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: No test => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
component: nbackup fix-version: 3.0 RC1 priority: major qa: cannot be tested type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvlad @firebird-automations