Issue Details (XML | Word | Printable)

Key: CORE-4945
Type: Improvement Improvement
Status: Open Open
Priority: Trivial Trivial
Assignee: Unassigned
Reporter: Pavel Zotov
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Mark inactive triggers in SHOW command (add new column to its output)

Created: 23/Sep/15 08:35 PM   Updated: 30/Sep/15 05:26 AM
Component/s: None
Affects Version/s: None
Fix Version/s: None

File Attachments: None
Image Attachments:

1. show-trigger-model-sample.PNG
(10 kB)

QA Status: No test


 Description  « Hide
Currently one may detect that trigger is INactive only by extracting its content. Command `show trigger' does not display such info neither in 2.5 nor in 3.0:

SQL> show trigger;
Trigger name Invalid
================================ =======
TRG_CONNECT

Table name Trigger name Invalid
================================ ================================ =======
AGENTS AGENTS_BI
DOC_LIST DOC_LIST_AIUD
DOC_LIST DOC_LIST_BIUD
. . .
SQL> show trigger trg_connect;
TRG_CONNECT, Sequence: 0, Type: ON CONNECT, Inactive
Trigger text:
=============================================================================
as
begin
    execute procedure sp_init_ctx;
    . . . .
end

It will be useful to add information about INactive trigger(s) to the output of SHOW TRIGGER command.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Adriano dos Santos Fernandes added a comment - 29/Sep/15 02:51 PM
It will grow up beyond 80 columns. Are we 'allowed' to do it in these days where nobody uses fixed 80-columns screens?

What we'll do anyway, when max. length of identifiers are increased?

Pavel Zotov added a comment - 29/Sep/15 04:28 PM
> It will grow up beyond 80 columns

If this column will has name 'Active' than cursor will stay exactly on 81-th column after last character - plese see attached sceen sample.

Adriano dos Santos Fernandes added a comment - 29/Sep/15 05:01 PM
I think it should be named Inactive, like it is for Invalid, and mark only the "In*" items.

Pavel Zotov added a comment - 30/Sep/15 05:26 AM
This column ("Inactive") could be abbreviated to "Inact." (w/o quotes, of course) - IMO one may easy to understand what this mean.
As for me, there is no problem about exceeding of 80th character: after 1st launch of cmd.exe we can change window properties (increase width) of this by right-clicking on its title bar + save and that's all. It will be auto-restored on all following launches.

PS. Oracle SQLPLUS has many cases when its output exceeds 80 chars, and nobody sees trouble with it :-)