Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database validation should skip/ignore VIEWS, EXTERNAL and GTT tables [CORE4962] #5253

Open
firebird-automations opened this issue Oct 13, 2015 · 7 comments
Open

Database validation should skip/ignore VIEWS, EXTERNAL and GTT tables [CORE4962] #5253

firebird-automations opened this issue Oct 13, 2015 · 7 comments
Labels
component: engine priority: minor type: improvement

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @pavel-zotov

Attachments:
online-validation-checks-views-and-external-table.fbk.7z

Unpack attached .7z and restore database from .fbk
Then run:

$fb_home/bin/fbsvcmgr service_mgr action_validate dbname <restored-database-name.fdb>

- with redirection to some log.

In that log one may see following lines:

17:03:08.61 Relation 137 (EXT_STOPTEST)
17:03:08.61 Relation 137 (EXT_STOPTEST) is ok
. . .
17:03:08.65 Relation 191 (V_QDISTR_SOURCE)
17:03:08.65 Relation 191 (V_QDISTR_SOURCE) is ok

17:03:08.65 Relation 192 (V_QSTORNED_SOURCE)
17:03:08.65 Relation 192 (V_QSTORNED_SOURCE) is ok

First relation is external table. Second and third - VIEWS with DDL like: 'select * from T1 union all select * from T2 union all ...'.
Validation should skip such kinds of DB objects.

PS. Also (IMHO) validation should always skip checking GTT because their data will be stored in unknown places - AFAIK, this is so at least for CS.
@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

Attachment: online-validation-checks-views-and-external-table.fbk.7z [ 12822 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

What exact problem do you see ?

@firebird-automations
Copy link
Collaborator Author

Commented by: @pavel-zotov

Ony one, minor: these lines can confuse those DBA who expect to see report about only *tables* and no anything else. So, this ticket rather should be marked as 'improvement' than 'bug'.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

issuetype: Bug [ 1 ] => Improvement [ 4 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Sean Leyne (seanleyne)

Edited "Summary" to improve language.

@firebird-automations
Copy link
Collaborator Author

Modified by: Sean Leyne (seanleyne)

summary: Online validation can take in account VIEWS and EXTERNAL table => Database validation should skip/ignore VIEWS, EXTERNAL and GTT tables

@firebird-automations
Copy link
Collaborator Author

Commented by: Claudio Valderrama C. (robocop)

It's unlikely that the engine will validate external tables and views, so they should be skipped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: engine priority: minor type: improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@firebird-automations