-
-
Notifications
You must be signed in to change notification settings - Fork 232
Real errors during connect to security database are hidden by Srp user manager. Errors should be logged no matter what AuthServer is used. [CORE4964] #5255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Modified by: @aafemtdescription: Whichever error happen during attach to security database, user will get only confusing and misguiding "Your user name and password are not defined.". Thus it is almost impossible to diagnose problems with security database. => Whichever error happen during attach to security database, user will get only confusing and misguiding "Your user name and password are not defined.". Thus it is almost impossible to diagnose problems with security database. To reproduce the problem you can replace security database with any garbage file. |
Commented by: @AlexPeshkoff This is as designed - in order to avoid potential problems with security actual reasons of inability to validate login/password are not broadcasted all over the world. PS. Debugging version does return that class of messages to the client. |
Commented by: @aafemt On Windows with release build of current trunk run as an application I got nothing in firebird.log. Edit: Legacy_UserManager indeed writes error into log. Srp as in default config - doesn't. |
Modified by: @pcisarstatus: Resolved [ 5 ] => Closed [ 6 ] |
Commented by: Sean Leyne (seanleyne) Alexander, While I fully support the need to not broadcast security issues, the current error message is very misleading. It would be better for another message to be returned ("Error occurred during login, please check server firebird.log for detail) which would clearly outline that the error is "system" related rather than simple user credentials. This would align with how other systems/OS deal with login errors (Windows reports "unable to connect to domain server" vs. "user credentials are invalid"). |
Modified by: @aafemtsummary: Real errors during connect to security database are hidden => Real errors during connect to security database are hidden by Srp user manager environment: Windows, default firebird.conf |
Modified by: @AlexPeshkoffFix Version: 3.0.0 [ 10048 ] summary: Real errors during connect to security database are hidden by Srp user manager => Real errors during connect to security database are hidden by Srp user manager. Errors should be logged no matter what AuthServer is used. |
Modified by: @AlexPeshkoffstatus: Closed [ 6 ] => Reopened [ 4 ] assignee: Alexander Peshkov [ alexpeshkoff ] resolution: Won't Fix [ 2 ] => |
Commented by: @pavel-zotov > Instead they are written to server's firebird.log <...> Can NOT reproduce this on WI-V3.0.4.32963, tried SS & CS, for both UserManager = Legacy_UserManager and Srp. Scenario: * Use following parameters in the firebird.conf: * Restart FB service * create database using default security.db, let its name will be: C:\MIX\firebird\QA\fbt-repo\tmp\noacc.fdb * open %FIREBIRD_HOME%\databases.conf and change there "SecurityDatabase" attribute for just created DB. noacc = C:\MIX\firebird\QA\fbt-repo\tmp\noacc.fdb * stop FB service, run: copy C:\MIX\firebird\fb30\security3.fdb C:\MIX\firebird\fb30\broken_sec.dat * start FB service, make attachment to 'localhost:noacc' as SYSDBA and add two users with diff. plugins:
* check that we can make attachments using these users:
* stop FB service, make copy of broken_sec.dat: * replace content of broken_sec.dat with garbage, e.g. with plain text:
* start FB service * try to connect using each of foo_leg & foo_srp. Result will be EXPECTED:
* open firtebird.log. IT WILL BE EMPTY. |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Deferred Test Details: See comment 08/May/18 04:44 AM |
Commented by: @AlexPeshkoff Pavel, please remove Legacy_Auth from your configuration (at all) and try again. Or at least place it after Srp. |
Commented by: @pavel-zotov Alex, it did not help.
|
Commented by: @AlexPeshkoff Right now rechecked: |
Commented by: @pavel-zotov I've found the reason: value of parameter WireCrypt. C:\MIX\firebird\fb30>C:\MIX\firebird\fb30\isql localhost:noacc -user foo_srp -pas 123 -q Otherwise record *will* be added and error looks like this: C:\MIX\firebird\fb30>C:\MIX\firebird\fb30\isql localhost:noacc -user foo_srp -pas 123 -q |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: Deferred => Done successfully Test Details: See comment 08/May/18 04:44 AM => |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Closed [ 6 ] Fix Version: 4.0 Beta 1 [ 10750 ] Fix Version: 3.0.4 [ 10863 ] |
Submitted by: @aafemt
Whichever error happen during attach to security database, user will get only confusing and misguiding "Your user name and password are not defined.". Thus it is almost impossible to diagnose problems with security database.
To reproduce the problem you can replace security database with any garbage file.
Commits: df2fb33 FirebirdSQL/fbt-repository@e4649b1
The text was updated successfully, but these errors were encountered: