New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure: snprintf function is already defined on MSVC 2015 [CORE5120] #5404
Comments
Commented by: @hvlad Windows build not used POSIX build scripts. |
Commented by: @davido I'm trying to build Firebird that is integrated in LlibreOffice with MSVC 14.0. As you may know, on Windows LibreOffice is built with Cygwin, and thus the whole POSIX build toolchain is available. For some external projects (Firebird is one of them), home made gcc-wrapper is used, that overloads CXX definition with real MSVC compiler paths so that in the end MSVC is used. With this approach regular POSIX build toolchain is used even for MSVC compiler and it works with MSVC 12.0 as expected: [1]. My task is to add support for MSVC 14.0 aka VS 2015 to LibreOffice. The only missing part is to support building Firebird in both 32bit and 64bit modes: [2]. [1] https://github.com/LibreOffice/core/blob/master/external/firebird/ExternalProject_firebird.mk#L39-L78 |
Modified by: Sean Leyne (seanleyne)description: Trying to use firebird with MSVC 2015 currently failing because of There is {code} macro in http://configure.in, that gets expanded to: [1]. Apparently one include or something is missing there. [1] http://paste.openstack.org/show/488502 => Trying to use firebird with MSVC 2015 currently failing because of broken discovery of snprintf and vsnprintf functions: There is {code} macro in http://configure.in, that gets expanded to: [1]. Apparently one include or something is missing there. [1] http://paste.openstack.org/show/488502 |
Commented by: @davido After fixing snprintf/vsnprintf issues, I'm running into new errors, that seem to be * [1] http://paste.openstack.org/show/488858 |
Commented by: @egorpugin I tried to compile fb with MSVC2015. |
Modified by: @hvladassignee: Vlad Khorsun [ hvlad ] |
Commented by: @hvlad I fixed issues with snprintf (in autoconfing_msvc.h) and user-defined literals. |
Commented by: @egorpugin Works flawlessly with cmake. ========== Build: 61 succeeded, 0 failed, 0 up-to-date, 2 skipped ========== --- Probably this should be asked on ML, not here. |
Commented by: @mariuz this can be closed patch is applied to master , 3.0 branch and 2.5 :) |
Modified by: Sean Leyne (seanleyne)status: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5.7 [ 10770 ] Fix Version: 3.0.2 [ 10785 ] |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Cannot be tested |
Submitted by: @davido
Votes: 1
Trying to use firebird with MSVC 2015 currently failing because of broken discovery of snprintf and vsnprintf functions:
There is
{code}
AC_CHECK_FUNCS(snprintf vsnprintf)
{code}
macro in http://configure.in, that gets expanded to: [1]. Apparently one include or something is missing there.
So that in the end the autoconfig.h tries to erroneously redefine already defined snprintf function: [2].
[1] http://paste.openstack.org/show/488502
[2] http://paste.openstack.org/show/488503
Commits: 713b68c 3c80ce0 1abb10f 9ae426a
The text was updated successfully, but these errors were encountered: