Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Samples of dbcrypt-related plugins contain references to internal files [CORE5134] #5418

Closed
firebird-automations opened this issue Mar 7, 2016 · 6 comments
Closed

Samples of dbcrypt-related plugins contain references to internal files [CORE5134] #5418

firebird-automations opened this issue Mar 7, 2016 · 6 comments
Assignees
@AlexPeshkoff
Labels
affect-version: 3.0 RC1 affect-version: 3.0 RC2 fix-version: 3.0.0 priority: major qa: cannot be tested type: bug

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @AlexPeshkoff

Votes: 1

Files DbCrypt.cpp and CryptKeyHolder.cpp in examples/dbcrypt contain the following lines:

#⁠include "firebird.h" // Needed for atomic support
#⁠include "../common/classes/fb_atomic.h"

That prevents users to build an example.

Commits: 666b110 0e32c78 FirebirdSQL/fbt-repository@0ae3d86 FirebirdSQL/fbt-repository@878d2c7
@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Fix Version: 3.0.0 [ 10740 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @aafemt

With current implementation of CryptManager, crypt plugin can safetly use non-atomic reference counters.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexPeshkoff AlexPeshkoff

Labels
affect-version: 3.0 RC1 affect-version: 3.0 RC2 fix-version: 3.0.0 priority: major qa: cannot be tested type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlexPeshkoff @firebird-automations