New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide location context (line/column numbers) for runtime errors raised inside EXECUTE BLOCK [CORE5216] #5496
Comments
Modified by: @dyemanovassignee: Dmitry Yemanov [ dimitr ] |
Commented by: @asfernandes It's funny that: - conversion error from string "" -> string denoted with double quotes is wrong - At procedure 'QWE123' -> metadata name denoted with single quotes is wrong Nothing to do with this ticket, but... :D |
Commented by: @dyemanov It's easy to fix the latter one (single quotes for metadata) but I'm afraid this will break a lot of existing tests for no real value. |
Modified by: @dyemanovreporter: Dmitry Yemanov [ dimitr ] => Boltik Evgeny [ bolt ] Fix Version: 3.0.1 [ 10730 ] Fix Version: 4.0 Alpha 1 [ 10731 ] |
Commented by: @asfernandes The later one is bigger than appear, for example, one could not know if 'X.Z' is "X.Z" by the user or Z from package X. So a correct fix would remove que quotes from the message and put then in the error arguments: Surely it could break applications, but today one depending on how we report is already possibly broken. |
Modified by: @dyemanovpriority: Major [ 3 ] => Minor [ 4 ] |
Commented by: @dyemanov It could be worth backporting to v2.5, but I leave it for another day. |
Commented by: Sean Leyne (seanleyne) Dmitry, Rather than "At anonymous block line: 5, col: 3" would suggest simply "At block line: 5, col: 3", "anonymous" could confuse users. |
Commented by: @dyemanov OK, I will adjust the wording a bit later. |
Modified by: @dyemanovFix Version: 2.5.6 [ 10721 ] |
Commented by: @pavel-zotov > Fix Version/s: 2.5.6, 3.0.1, 4.0 Alpha 1 For 2.5.6 one may to find that fix is incompleted.
|
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Deferred Test Details: Waiting for reply on issue 29/Apr/16 07:34 PM. |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: Deferred => Done with caveats Test Details: Waiting for reply on issue 29/Apr/16 07:34 PM. => Implemented only for 3.0 and above; 2.5.x does not show all of expected lines. |
Submitted by: Boltik Evgeny (bolt)
set term ^;
select cast('' as timestamp) from rdb$database
^
-- ERROR:
-- Statement failed, SQLSTATE = 22018
-- conversion error from string ""
recreate procedure qwe123
returns(res timestamp)
as
begin
res = cast('' as timestamp);
suspend;
end
^
execute procedure qwe123
^
-- ERROR:
-- Statement failed, SQLSTATE = 22018
-- conversion error from string ""
-- At procedure 'QWE123' line: 5, col: 3
execute block
returns(res timestamp)
as
begin
res = cast('' as timestamp);
suspend;
end
^
-- ERROR:
-- Statement failed, SQLSTATE = 22018
-- conversion error from string ""
Something like "At anonymous block line: 5, col: 3" should be reported in this case.
Commits: 83bf8f4 1d2eed6 25313da FirebirdSQL/fbt-repository@1df2843 FirebirdSQL/fbt-repository@08d97b2 FirebirdSQL/fbt-repository@f9e0603 FirebirdSQL/fbt-repository@9a371b4 FirebirdSQL/fbt-repository@dbc835d FirebirdSQL/fbt-repository@51da852 FirebirdSQL/fbt-repository@61b4df7 FirebirdSQL/fbt-repository@1d77efa FirebirdSQL/fbt-repository@2ce70a5 FirebirdSQL/fbt-repository@d7e96b9 FirebirdSQL/fbt-repository@0d087a5 FirebirdSQL/fbt-repository@1bdd293 FirebirdSQL/fbt-repository@5fd04e1 FirebirdSQL/fbt-repository@41423ff FirebirdSQL/fbt-repository@60b63a9 FirebirdSQL/fbt-repository@0211556 FirebirdSQL/fbt-repository@3f69053 FirebirdSQL/fbt-repository@fd62429 FirebirdSQL/fbt-repository@ef60cda FirebirdSQL/fbt-repository@2775aef FirebirdSQL/fbt-repository@b5278dc FirebirdSQL/fbt-repository@a0457c3 FirebirdSQL/fbt-repository@25f8bcf FirebirdSQL/fbt-repository@5cb38d3 FirebirdSQL/fbt-repository@14ceb75 FirebirdSQL/fbt-repository@d034aed FirebirdSQL/fbt-repository@3f34dba FirebirdSQL/fbt-repository@9c5ba19
====== Test Details ======
Implemented only for 3.0 and above; 2.5.x does not show all of expected lines.
The text was updated successfully, but these errors were encountered: