Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor performance optimization - avoid additional database attachment from security objects mapping code [CORE5433] #5705

Closed
firebird-automations opened this issue Dec 30, 2016 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @AlexPeshkoff

Make mapUser() function when invoked from Attachment::attachDatabase() use current (newly created) attachment instead of attaching to same database once more.

Commits: 8e1421d 5e70385

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

description: Make mapUser() function when invoked from Attachment::attachDatabase() use current (newly created) attachment instead of attaching to same database once more => Make mapUser() function when invoked from Attachment::attachDatabase() use current (newly created) attachment instead of attaching to same database once more.

environment: Specially important for CS - temporal attachment from mapUser() is created once per process lifetime (repeated only in case of mapping changes) making therefore that overhead not important in case of SS.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Alpha 1 [ 10731 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Can't discover difference in trace logs, waiting for Alex reply, letter 08-mar-2017 22:18.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Done successfully

Test Details: Can't discover difference in trace logs, waiting for Alex reply, letter 08-mar-2017 22:18. =>

Test Specifics: [Architecture (SS/CS) specific]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment