Commented by: @mrotteveel

Although you are right, please ensure this is fixed in a backwards compatible way, as this has been this way since the introduction of SQL:2003-style create trigger in Firebird 2.1

Commented by: @asfernandes

Clauses could be made to be anywhere, but definitelly it would be wrong to have POSITION in the middle of something.

My opinion is to fix the error in v4. People should test their applications when migrating major versions and DDL is more flexible to changes.

Commented by: @pavel-zotov

It seems that now one can NOT to use old syntax of [re]create trigger DDL.

This is what i see in the build of 24-may-2017:

C:\MIX\firebird\QA\fbt-repo\tmp>C:\MIX\firebird\FB40Cs\isql /:e40 -z -i c5545.sql
ISQL Version: WI-T4.0.0.651 Firebird 4.0 Unstable
Server version:
WI-T4.0.0.651 Firebird 4.0 Unstable
WI-T4.0.0.651 Firebird 4.0 Unstable/tcp (csprog)/P16
WI-T4.0.0.651 Firebird 4.0 Unstable/tcp (csprog)/P16

recreate table test\(id int\);

\-\- worked always:
recreate trigger test\_bi before insert
                 position 1
                 on test
as begin end;

-- did NOT work before fix core-5545, must work now:
recreate trigger test_bi before insert
on test
position 1
as begin end;
Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -104
-Token unknown - line 3, column 21
-position
At line 13 in file c5545.sql

(and this is expected on THAT build)

But on current build (19-jun-2017) we have:

C:\MIX\firebird\QA\fbt-repo\tmp>C:\MIX\firebird\FB40\isql /:e40 -z -i c5545.sql
ISQL Version: WI-T4.0.0.680 Firebird 4.0 Alpha 1
Server version:
WI-T4.0.0.680 Firebird 4.0 Alpha 1
WI-T4.0.0.680 Firebird 4.0 Alpha 1/tcp (csprog)/P16
WI-T4.0.0.680 Firebird 4.0 Alpha 1/tcp (csprog)/P16

recreate table test\(id int\);

\-\- worked always:
recreate trigger test\_bi before insert
                 position 1
                 on test
as begin end;

Statement failed, SQLSTATE = 42000
Dynamic SQL Error
-SQL error code = -104
-Token unknown - line 2, column 22
-position
At line 6 in file c5545.sql