Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong formatting of "Elapsed time" in isql [CORE5586] #5853

Closed
firebird-automations opened this issue Jul 18, 2017 · 3 comments
Closed

Wrong formatting of "Elapsed time" in isql [CORE5586] #5853

firebird-automations opened this issue Jul 18, 2017 · 3 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @cincuranet

Running command with "set stats on" produces (among others):
Elapsed time= xxx sec

Other pieces have space after the name. So it should be:
Elapsed time = xxx sec

Commits: 02e4e83

@firebird-automations
Copy link
Collaborator Author

Commented by: @cincuranet

This is easy to fix, I can PR it. Is it enough to fix it in "isql.h"? The rest will be regenerated?

@firebird-automations
Copy link
Collaborator Author

Commented by: @dyemanov

Nope, the fix must belong to msgs/message2.sql, facility 17, msg 44. isql.epp and isql.h (search for REPORT1 in both) may be fixed too, this is just self-documentation (it's not generated).

@firebird-automations
Copy link
Collaborator Author

Commented by: @cincuranet

OK, here's the PR: #98 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants