Issue Details (XML | Word | Printable)

Key: CORE-5868
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Paul Beach
Reporter: Hamish Moffatt
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Firebird Core

fbintl exports internal functions on darwin

Created: 10/Jul/18 02:26 AM   Updated: 30/Jul/19 06:34 AM
Component/s: Build Issues / Porting
Affects Version/s: 2.5.8
Fix Version/s: 2.5.9

File Attachments: 1. Text File core-5868.patch (0.6 kB)

Environment: macOS

QA Status: Cannot be tested


 Description  « Hide
The Darwin build of fbintl (libfbintl.dylib) exports all functions, including new and delete, because the makefile darwin.defaults fails to pass the symbols list to the linker.

This is already fixed in v3 in commit ade505bed5506d4fb4f094e2d8ee1345f9af23fa.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Hamish Moffatt added a comment - 10/Jul/18 02:53 AM
It looks like the UDF and TRACE libraries are also missing their symbol lists.

Hamish Moffatt added a comment - 10/Jul/18 08:42 AM
Here is my patch to fix the fbintl build for 2.5.8. I did not fix the trace build but it looks like it also needs a similar change.

Paul Beach added a comment - 10/Jul/18 12:12 PM
Committed to B2_5_Release

Hamish Moffatt added a comment - 10/Jul/18 10:53 PM

Hamish Moffatt added a comment - 30/Jul/19 05:53 AM
According to the 2.5.9 release notes this is fixed, but it isn't.

darwin.defaults line 56 says
LINK_INTL = $(LIB_LINK) $(LINK_INTL_SYMBOLS) $(LIB_BUNDLE_OPTIONS)

but LINK_INTL_SYMBOLS should be LINK_FBINTL_SYMBOLS.

Paul Beach added a comment - 30/Jul/19 06:34 AM
I have committed this to B2_5_Release.