New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fbintl exports internal functions on darwin [CORE5868] #6127
Comments
Modified by: Hamish Moffatt (hmoffatt)summary: fbintl exporting internal functions on darwin => fbintl exports internal functions on darwin |
Commented by: Hamish Moffatt (hmoffatt) It looks like the UDF and TRACE libraries are also missing their symbol lists. |
Commented by: Hamish Moffatt (hmoffatt) Here is my patch to fix the fbintl build for 2.5.8. I did not fix the trace build but it looks like it also needs a similar change. |
Modified by: Hamish Moffatt (hmoffatt)Attachment: core-5868.patch [ 13281 ] |
Modified by: @paulbeachassignee: Paul Beach [ pbeach ] |
Commented by: @paulbeach Committed to B2_5_Release |
Modified by: @paulbeachstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 2.5.9 [ 10862 ] |
Commented by: Hamish Moffatt (hmoffatt) I don't see this on Github in B2_5_Release? |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Cannot be tested |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Closed [ 6 ] |
Commented by: Hamish Moffatt (hmoffatt) According to the 2.5.9 release notes this is fixed, but it isn't. darwin.defaults line 56 says but LINK_INTL_SYMBOLS should be LINK_FBINTL_SYMBOLS. |
Commented by: @paulbeach I have committed this to B2_5_Release. |
Submitted by: Hamish Moffatt (hmoffatt)
Attachments:
core-5868.patch
The Darwin build of fbintl (libfbintl.dylib) exports all functions, including new and delete, because the makefile darwin.defaults fails to pass the symbols list to the linker.
This is already fixed in v3 in commit ade505b.
Commits: 237bb90
The text was updated successfully, but these errors were encountered: