Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fbintl exports internal functions on darwin [CORE5868] #6127

Closed
firebird-automations opened this issue Jul 10, 2018 · 12 comments
Closed

fbintl exports internal functions on darwin [CORE5868] #6127

firebird-automations opened this issue Jul 10, 2018 · 12 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Hamish Moffatt (hmoffatt)

Attachments:
core-5868.patch

The Darwin build of fbintl (libfbintl.dylib) exports all functions, including new and delete, because the makefile darwin.defaults fails to pass the symbols list to the linker.

This is already fixed in v3 in commit ade505b.

Commits: 237bb90

@firebird-automations
Copy link
Collaborator Author

Modified by: Hamish Moffatt (hmoffatt)

summary: fbintl exporting internal functions on darwin => fbintl exports internal functions on darwin

@firebird-automations
Copy link
Collaborator Author

Commented by: Hamish Moffatt (hmoffatt)

It looks like the UDF and TRACE libraries are also missing their symbol lists.

@firebird-automations
Copy link
Collaborator Author

Commented by: Hamish Moffatt (hmoffatt)

Here is my patch to fix the fbintl build for 2.5.8. I did not fix the trace build but it looks like it also needs a similar change.

@firebird-automations
Copy link
Collaborator Author

Modified by: Hamish Moffatt (hmoffatt)

Attachment: core-5868.patch [ 13281 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @paulbeach

assignee: Paul Beach [ pbeach ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @paulbeach

Committed to B2_5_Release

@firebird-automations
Copy link
Collaborator Author

Modified by: @paulbeach

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.9 [ 10862 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Hamish Moffatt (hmoffatt)

I don't see this on Github in B2_5_Release?
https://github.com/FirebirdSQL/firebird/tree/B2_5_Release/builds/posix

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Hamish Moffatt (hmoffatt)

According to the 2.5.9 release notes this is fixed, but it isn't.

darwin.defaults line 56 says
LINK_INTL = $(LIB_LINK) $(LINK_INTL_SYMBOLS) $(LIB_BUNDLE_OPTIONS)

but LINK_INTL_SYMBOLS should be LINK_FBINTL_SYMBOLS.

@firebird-automations
Copy link
Collaborator Author

Commented by: @paulbeach

I have committed this to B2_5_Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants