Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlock when attaching to bugchecked database [CORE5950] #6206

Closed
firebird-automations opened this issue Oct 24, 2018 · 7 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Basil A. Sidorov (basid)

Current code ignores databases with DBB_bugcheck flag - i.e. for new attaches new database is created. This is unsafe cause in SS for some time coexist 2 database blocks using same database file, and among others may cause mentioned deadlock.

Commits: 2ce876c ef57295

====== Test Details ======

Can't get any reference on client side about Database instances that are assigned to attachment, --> can not check that new attachment get reference to the same Db object rather that to new (as it was before fix).
Value of _db_handle can be obtained in fdb, but its value is the same on FB builds before and after fix.

Discussed with dimitr and alex, letters 13.12.2018 - 26.12.2018

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

reporter: Alexander Peshkov [ alexpeshkoff ] => Basil A. Sidorov [ basid ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Use safe behavior - raise an error when attaching bugchecked database.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 1 [ 10750 ]

Fix Version: 3.0.5 [ 10885 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

Test Details: Sent letter to dimitr and alex, 13.12.18 08:30. Waiting for reply.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: Deferred => Cannot be tested

Test Details: Sent letter to dimitr and alex, 13.12.18 08:30. Waiting for reply. => Can't get any reference on client side about Database instances that are assigned to attachment, --> can not check that new attachment get reference to the same Db object rather that to new (as it was before fix).
Value of _db_handle can be obtained in fdb, but its value is the same on FB builds before and after fix.

Discussed with dimitr and alex, letters 13.12.2018 - 26.12.2018

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment