New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iconv / libiconv 1.15 vs libc / libiconv_open | common/isc_file.cpp [CORE5989] #6239
Comments
Modified by: @AlexPeshkoffassignee: Alexander Peshkov [ alexpeshkoff ] |
Commented by: @AlexPeshkoff Try this patch and report here does it help or not |
Modified by: @AlexPeshkoffAttachment: iconv.patch [ 13318 ] |
Commented by: Dilyan Palauzov (dpa-firebirdsql_aegee.org) With the patch applied, and doing "mkdir m4 && autoreconf" libtoolize reports "putting macros in AC_CONFIG_MACRO_DIRS, 'm4'." and "Consider adding '-I m4' to ACLOCAL_AMFLAGS in http://Makefile.am". Calling afterwards "./configure --with-builtin-tommath" prints: checking for library containing iconv_open... none required Eventually "make" emits: make -C gen firebird make -C /src/Firebird-3.0.4.33054-0/extern/libtommath -f makefile.shared LIBTOOL= So libtool is not present before --mode=CC. In gen/Release/firebird/lib/ there is libtommath and -liconv is passed to the linker when common.a is involved, which shall be good. |
Commented by: @AlexPeshkoff Please contact fb-devel list re another build issue. Will be good to provide switches passed to http://autogen.sh. |
Modified by: @AlexPeshkoffstatus: Open [ 1 ] => Resolved [ 5 ] resolution: Fixed [ 1 ] Fix Version: 4.0 Beta 1 [ 10750 ] Fix Version: 3.0.5 [ 10885 ] |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Resolved [ 5 ] QA Status: No test => Cannot be tested |
Modified by: @pavel-zotovstatus: Resolved [ 5 ] => Closed [ 6 ] |
Submitted by: Dilyan Palauzov (dpa-firebirdsql_aegee.org)
Attachments:
iconv.patch
Running ./configure reports:
checking iconv.h usability... yes
checking iconv.h presence... yes
checking for iconv.h... yes
...
checking for library containing iconv_open... none required
On my system I have /usr/include/iconv.h from libc and /usr/local/include/iconv.h from libiconv-1.15 . The latter contains "#define iconv_open libiconv_open". This file is included in src/common/isc_file.cpp and there the latter macro is expanded. So isc_file.cpp references libiconv_open(). For this to work -liconv must be passed to the linker, but it is not. In turn linking towards common.a(isc_files.cpp) fails, as libiconv_open() cannot be resolved.
Commits: 5a36c40 9d1d37b
The text was updated successfully, but these errors were encountered: