Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system procedure named "TRANSITIONS" without "RDB$" prefix [CORE6002] #6252

Closed
firebird-automations opened this issue Feb 17, 2019 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Segey Khalyutin (notesoft)

select rdb$procedure_name, RDB$SYSTEM_FLAG from RDB$PROCEDURES where RDB$SYSTEM_FLAG = 1

@firebird-automations
Copy link
Collaborator Author

Commented by: @mrotteveel

That is incorrect. That procedure is part of the RDB$TIME_ZONE_UTIL package, so its name is actually RDB$TIME_ZONE_UTIL.TRANSITIONS when called. See also https://github.com/FirebirdSQL/firebird/blob/master/doc/sql.extensions/README.time_zone.md#procedure-transitions

@firebird-automations
Copy link
Collaborator Author

Commented by: Segey Khalyutin (notesoft)

now

create procedure TRANSITIONS
returns( result integer )
as
begin
result = 1;
suspend;
end

select * from TRANSITIONS

is susseful.

Package is good idea, but current code not used it.
Our database upgrade code comparator is stup on this. We are fix it by use rdb$system_flag.

Are You sure, that wil be no conflict with user procedures in future and all system Package items wil be not "reserved" words ?...

@firebird-automations
Copy link
Collaborator Author

Commented by: @mrotteveel

Package are a concept since Firebird 3, and RDB$TIME_ZONE_UTIL is a package, and TRANSITIONS is a procedure in that package. If you want to properly discern normal procedures from procedures in packages (whether they are system packages or normal packages) you'll need to take the RDB$PACKAGE_NAME into account together with RDB$PROCEDURE_NAME.

There is no guarantee whatsoever that certain words do not become reserved words in the future, but in this case it is unlikely (at least, not for this purpose).

@firebird-automations
Copy link
Collaborator Author

Commented by: Segey Khalyutin (notesoft)

Thanks, OK

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Won't Fix [ 2 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant