Issue Details (XML | Word | Printable)

Key: CORE-6075
Type: Bug Bug
Status: Open Open
Priority: Critical Critical
Assignee: Vlad Khorsun
Reporter: Pavel Cisar
Votes: 0
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Trace configuration is not validated on session start

Created: 03/Jun/19 11:41 AM   Updated: 07/Jun/19 08:41 AM
Component/s: Engine
Affects Version/s: 3.0.4
Fix Version/s: None

QA Status: No test


 Description  « Hide
The trace configuration that is part of "start trace" API call is not parsed/validated on input. The configuration is parsed when other attachment will have something to trace and detect new trace session. At this point it's too late to report it correctly to the user. As this is not even logged in firebird.log, the final result is that all configuration errors are swallowed and trace produces no output.

Making an error (typo, missing parenthesis or other) in configuration is easy. User can even mistakenly send (correct because previously tested and working) configuration in Firebird 2.5 format to the Firebird 3.0. As engine just happily starts the trace session that does not report anything wrong at any time and just produces nothing, it could easily lead to deep frustration in search for cause of the problem. The issue is that configuration is NOT validated on input (start trace session request). Engine should validate it and refuse to start the trace session with good error description where the problem is.

This was verified on 3.0.4, but almost certainly affects all versions since 2.5 up to 4.0 beta 1.


 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Vlad Khorsun made changes - 06/Jun/19 08:23 AM
Field Original Value New Value
Assignee Vlad Khorsun [ hvlad ]