Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"SIMILAR TO" hangs when processing parenthesis [CORE6088] #6338

Closed
firebird-automations opened this issue Jun 28, 2019 · 12 comments
Closed

"SIMILAR TO" hangs when processing parenthesis [CORE6088] #6338

firebird-automations opened this issue Jun 28, 2019 · 12 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @dmitry-starodubov

Votes: 1

This query works fine on 2.5 but hangs on 3.X:

select 1 from RDB$DATABASE
where 'a-b c(d)'
similar to '[[:WHITESPACE:]a-z\-]{0,199}' escape '\';

Commits: 28e1874

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@romansimakov
Copy link
Collaborator

It's not correct to close the issue which affects version 3 as fixed if fix does not affect version 3. Isn't it? Let's backport the fix to versio 3 as well.

@asfernandes
Copy link
Member

It's not correct to close the issue which affects version 3 as fixed if fix does not affect version 3. Isn't it?

That happens a lot. Isn't it?

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Oct 5, 2021 via email

@romansimakov
Copy link
Collaborator

It's not correct to close the issue which affects version 3 as fixed if fix does not affect version 3. Isn't it?

That happens a lot. Isn't it?

No. It should not happend. It's a regression and an application working on 2.5 cannot work properly on 3.0.

@romansimakov
Copy link
Collaborator

On 10/5/21 2:43 PM, Adriano dos Santos Fernandes wrote: It's not correct to close the issue which affects version 3 as fixed if fix does not affect version 3. Isn't it? That happens a lot. Isn't it?
Yes. Sometimes backporting a fix means too many changes in code of old version. One can get 3.99 instead 3.0 in that case :)

I'm not so sure about that. 3.99 has a lot of other changes. It might be possible to use it for testing, test migration but it's not always easy just replace 3.0 by 3.99. Especially in enterprise. In this case let's 3.0 version as unsupported.

@asfernandes
Copy link
Member

And fixing it in 3.0 would much probably means introduce another bug fixed in 3.0.

It's why the regex engine was completely changed to re2 in 4.0.

Backport of that is too much for 3.0.

@romansimakov
Copy link
Collaborator

I see and would agree if there is a workaround. But there are several cases when there is no error. Server just returns wrong result. IMO it is too much for server usage )

@romansimakov
Copy link
Collaborator

Let's backport re2 to 3.0 :) We are ready to test before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants