Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.5.9 Regression: MON$Attachments.MON$Remote_Address now includes the remote TCP port number [CORE6151] #6400

Closed
firebird-automations opened this issue Oct 4, 2019 · 9 comments
Closed

v2.5.9 Regression: MON$Attachments.MON$Remote_Address now includes the remote TCP port number [CORE6151] #6400

firebird-automations opened this issue Oct 4, 2019 · 9 comments
Labels
affect-version: 2.5.9 component: engine priority: minor resolution: wontfix type: bug

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Attila Molnár (e_pluribus_unum)

Before 2.5.9 mon$attachments.mon$remote_address returned just IP, e.g.: "192.168.0.1".
With 2.5.9 it returns IP + port number, e.g.: "192.168.0.1/55970".

It made broke some of our code. (We are comparing mon$remote_address to outer source IP without port)

It this intentional, a side effect or a bug? Changelog doesn't mentions this change.
@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

See CORE2493

@firebird-automations
Copy link
Collaborator Author

Commented by: Sean Leyne (seanleyne)

CORE2493 is about the firebird.log, IMO that should have nothing to do with the value stored in the mon$attachments.mon$remote_address. The TCP port used by the remote system should be in a new/separate field

@firebird-automations
Copy link
Collaborator Author

Modified by: Sean Leyne (seanleyne)

description: Hi!

Before 2.5.9 mon$attachments.mon$remote_address returned just IP, e.g.: "192.168.0.1".
With 2.5.9 it returns IP + port number, e.g.: "192.168.0.1/55970".

It made broke some of our code. (We are comparing mon$remote_address to outer source IP without port)

It this intentional, a side effect or a bug? Changelog doesn't mentions this change.

Thank you!

=>

Before 2.5.9 mon$attachments.mon$remote_address returned just IP, e.g.: "192.168.0.1".
With 2.5.9 it returns IP + port number, e.g.: "192.168.0.1/55970".

It made broke some of our code. (We are comparing mon$remote_address to outer source IP without port)

It this intentional, a side effect or a bug? Changelog doesn't mentions this change.

summary: Firebird 2.5.9 mon$attachments.mon$remote_address => v2.5.9 Regression: MON$Attachments.MON$Remote_Address now includes the remote TCP port number

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

a) Remote port is a part of remote address, passed from network server to the engine as part of remote address and presented to the end user as part of remote address
b) Remote port is specific for TCP protocol and have no sense for other protocols
c) To create new field in system table there must be much more serious reason

@EPluribusUnum
Copy link

FB4.0 returns IPv6 adress. + port number in MON$REMOTE_ADDRESS. Is there a way to get IPv4 address + port?

@mrotteveel
Copy link
Member

I believe that depends on whether the connection is established using IPv6 or IPv4.

@EPluribusUnum
Copy link

@mrotteveel , yep. Using IPv4 in connection string instead of computername reported IPv4. Thank you.

@EPluribusUnum
Copy link

You can close this issue. Thank you.

@mrotteveel
Copy link
Member

You can also explicitly enforce IPV4 by using the inet4 connection string: inet4://host:port/database

@hvlad hvlad closed this as completed May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affect-version: 2.5.9 component: engine priority: minor resolution: wontfix type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@EPluribusUnum @mrotteveel @hvlad @firebird-automations