Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBSTRING of non-text/-blob is described to return NONE character set in DSQL [CORE6160] #6409

Closed
firebird-automations opened this issue Oct 15, 2019 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @asfernandes

The correct character set should be ASCII.

set sqlda_display on;
select substring(1 from 1 for 1) from rdb$database;
select substring(current_date from 1 for 1) from rdb$database;

Commits: 327c642 329a5c0

@firebird-automations
Copy link
Collaborator Author

Commented by: Sean Leyne (seanleyne)

Adriano,

it seems odd that ASCII character set would be used. I would have expected the character set to be, either: (a) the character set of the database [but I don't see that value exposed anywhere], or (b) the character set of the DB connection,

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

If DB and connection charset are none, it would be described as NONE. Always using ASCII (as numbers/dates are representable on it) it's more complete IMO.

But if connection charset is something else, DSQL will convert and describe with the connection charset, as it does with everything.

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

assignee: Adriano dos Santos Fernandes [ asfernandes ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @asfernandes

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0 Beta 2 [ 10888 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Done successfully

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants