Issue Details (XML | Word | Printable)

Key: CORE-6189
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Alexander Peshkov
Reporter: Vadim Zeitlin
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
Firebird Core

Building bundled libtommath fails

Created: 15/Nov/19 05:12 PM   Updated: 08/Feb/20 09:38 PM
Component/s: Build Issues / Porting
Affects Version/s: 3.0.5
Fix Version/s: 3.0.6

Environment: Debian Buster, but affects all Unix systems

QA Status: Cannot be tested


 Description  « Hide
TL;DR: please undo the apparently accidentally committed part of 78376b0797aa994538169a20abb9800a361f82b5 which seems to be a local debug check


Building fails when using --with-builtin-tommath configure option because gen/Makefile contains this line

    $(MAKE) -C $(ROOT)/extern/libtommath -f makefile.shared LIBTOOL=$(LIBTOOL)

while extern/libtommath/makefile.shared contains this

     ifndef LIBTOOL
     LIBTOOL=libtool
     endif

So LIBTOOL ends up being defined, but empty, meaning that all attempts to use it fail.

The problematic line in gen/Makefile comes from builds/posix/Makefile.in and was added to it by 78376b0797aa994538169a20abb9800a361f82b5 seemingly accidentally, as it doesn't bear any relationship to the commit message. AFAICS the first chunk of this commit should be just reverted, which would fix the problem. Alternatively, fix extern/libtommath/makefile.shared to use ifeq($(LIBTOOL),) instead of checking if it's defined.

Note that this commit is in 3.0 branch only, so it doesn't affect master/4.0.


 All   Comments   Change History   Subversion Commits      Sort Order: Descending order - Click to sort in ascending order
Alexander Peshkov added a comment - 08/Feb/20 08:33 AM
A bit strange that Debian needs this option. Use of system library is IMO preferred.