Issue Details (XML | Word | Printable)

Key: CORE-6274
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Adriano dos Santos Fernandes
Reporter: Adriano dos Santos Fernandes
Votes: 0
Watchers: 2

If you were logged in you would be able to see more operations.
Firebird Core

Increase parse speed of long queries

Created: 03/Apr/20 04:34 PM   Updated: 04/Apr/20 09:41 PM
Component/s: Engine
Affects Version/s: 4.0 Beta 1, 3.0.5
Fix Version/s: 4.0 Beta 2, 3.0.6

QA Status: Cannot be tested

 Description  « Hide
With CORE-6246 tests, for example, parse is very slow because parser keeps adding stack space in 16 increments, which makes lots of realloc and copies.

In a test (slow vm and debug build), changing YYSTACKGROWTH to 128 improves the test from 33s to 7s.

 All   Comments   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Alexander Peshkov added a comment - 03/Apr/20 04:45 PM
Would not exponential growth (like in our string and Array) be even better? It was chosen exactly for the same reason as you describe above.

Adriano dos Santos Fernandes added a comment - 03/Apr/20 05:02 PM
Yes, I believe, but for now I preferred a very simple fix with a good balance between simplicity and improvement.

Adriano dos Santos Fernandes added a comment - 04/Apr/20 09:41 PM
I did a more real world test with release build in better machine: 13,9s to 0,25s.