Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: Upgrade to libtommath1 (link with libtommath.so.1) [CORE6313] #6554

Closed
firebird-automations opened this issue May 20, 2020 · 14 comments
Closed

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Basil A. Sidorov (basid)

Firebird 4.0 beta 2 uses libncurses6 from base system "newest linuxes" (f.e. - CentOS 8 and Ubuntu19).
"Newest linuxes" also migrate to libtommath1 (libtommath.so.1), but FB40b2 linked with libtommath.so.0.
In coordination need link with libtommath.so.1

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Appears to be useless change. Firebird 4 currently can be installed on both types of systems with tommath 0 and 1.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Won't Fix [ 2 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

I think there is a problem really.

Every time I try to install the binaries package in new Ubuntu I have a problem.

@firebird-automations
Copy link
Collaborator Author

Modified by: @pcisar

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

@adriano - do you mean FB3 or FB4 binaries?
Can you try with current fb4 snapshot?

@firebird-automations
Copy link
Collaborator Author

Commented by: @asfernandes

Alex, after installing linbcurses5, looks like ok now in Ubuntu 20.04.

However I must say I don't like that our installer creates symlink for libtommath.so.0 in /lib/x86_64-linux-gnu as that system directories changes are generally handled by packages.

If I move this symlink to /opt/firebird/lib things still works. So why not use /opt/firebird/lib?

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

System directory for artificial symlink was chosen on purpose. After firebird installation required library can be installed (or at least attempted to install) into target box by native package manager. With symlink in /opt/firebird/lib they get 2 symlinks to 2 different copies of library, and it's hard to predict which one will be used.

@asfernandes
Copy link
Member

It looks like things are still problematic.

Our CI (for example https://github.com/FirebirdSQL/firebird/runs/8061596033?check_suite_focus=true) is failing with ./install.sh: 5: libtinfo.so.6: not found, but when this is fixed we have Please install required library 'tommath' before firebird, after it repeat firebird install error.

If package is built with system tommath.so.1, install should not check for libtommath.so.0, I think.

But even with this check, I believe install should not fail in this case (build and install in the same system)

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Aug 29, 2022

@asfernandes
That link has no failed jobs.

@asfernandes
Copy link
Member

@asfernandes That link has no failed jobs.

Yes, but last row of build says ./install.sh: 5: libtinfo.so.6: not found. This does not seems as a recoverable thing, so I suspect it's exiting with wrong error code.

When I tried to fix it (together with changes related to filenames) I had the error about tommath and the job failing. (https://github.com/asfernandes/firebird/runs/8069509348?check_suite_focus=true)

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Aug 29, 2022 via email

@AlexPeshkoff
Copy link
Member

AlexPeshkoff commented Aug 29, 2022 via email

@asfernandes
Copy link
Member

In original case there were no problems with tommath.

Sorry, in the modified build tommath errors was happening because I missed to change an amd64 string in the shell script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants