[#CORE-6413] Remove PIDFile/-pidfile directive/option from firebird Super(Server/Classic) systemd unit

Firebird Core

Remove PIDFile/-pidfile directive/option from firebird Super(Server/Classic) systemd unit

Created: 08/Oct/20 05:05 AM Updated: 10/Oct/20 03:30 PM

Component/s:

Installation

Affects Version/s:

4.0 Beta 2, 3.0.6

Fix Version/s:

3.0.7, 4.0 RC 1

QA Status:

Cannot be tested

Description

« Hide

If forking/simple systemd service unit uses PIDFile directive, that file should contain pid of main control process from ExecStart directive.
For Firebird SuperServer/SuperClassic - fbguard, but pid-file contain pid of child process (firebird).
That prevent systemd from normal stop/restart FB service if fbguard restarted child firebird process.
As long as PIDFile directive are optional for systemd and -pidfile option are unneeded for fbguard - they should removed from unit.

Current unit (part):
Type=forking
PIDFile=/var/run/firebird/default.pid
ExecStart=${fb_install_prefix}/bin/fbguard -pidfile /var/run/firebird/default.pid -daemon -forever
StandardError=syslog

Suggest or:
Type=forking
ExecStart=${fb_install_prefix}/bin/fbguard -daemon -forever
StandardError=syslog

or:
Type=simple
ExecStart=${fb_install_prefix}/bin/fbguard -forever
StandardError=syslog

All

Comments

Change History

Subversion Commits

Sort Order:

Alexander Peshkov made changes - 08/Oct/20 07:22 AM

Field	Original Value	New Value
Assignee		Alexander Peshkov [ alexpeshkoff ]

Alexander Peshkov made changes - 09/Oct/20 09:15 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Fix Version/s		4.0 RC 1 [ 10930 ]
Fix Version/s		3.0.7 [ 10940 ]
Resolution		Fixed [ 1 ]

Pavel Zotov made changes - 10/Oct/20 03:30 PM

Status	Resolved [ 5 ]	Resolved [ 5 ]
QA Status	No test	Cannot be tested

Pavel Zotov made changes - 10/Oct/20 03:30 PM

Status

Resolved [ 5 ]

Closed [ 6 ]