Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event delivery could be missed when local (XNET) protocol is used [CORE6488] #6718

Closed
firebird-automations opened this issue Feb 15, 2021 · 9 comments
Closed

Event delivery could be missed when local (XNET) protocol is used [CORE6488] #6718

firebird-automations opened this issue Feb 15, 2021 · 9 comments
Assignees
@hvlad
Labels
affect-version: 2.5.9 affect-version: 3.0.7 affect-version: 4.0 RC 1 component: api / client library component: engine fix-version: 3.0.8 fix-version: 4.0.0 priority: major qa: cannot be tested type: bug

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @hvlad

Is related to CORE923

The bug was reported at https://www.sql.ru/forum/1333365/

The problem could happen when:
- the op_event packet is longer than the XNET transmission buffer length (100 bytes), and
- client start to read data a bit later than server write first 100 bytes.

In this case race between writer and reader could happen and reader could miss first 100 bytes of the packet contents.

The bug is close to impossible to reproduce without artificial manipulation by running threads using debugger.
It might explain why it was not detected so far, since XNET was introduced.

Commits: 4fd96ee 197615c
@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

assignee: Vlad Khorsun [ hvlad ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

Link: This issue is related to CORE923 [ CORE923 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Fix is committed into v3

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

Fix Version: 4.0.0 [ 10931 ]

Fix Version: 3.0.8 [ 10960 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @hvlad

Fix is committed into v4 also

@firebird-automations
Copy link
Collaborator Author

Modified by: @hvlad

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Deferred

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Closed [ 6 ] => Closed [ 6 ]

QA Status: Deferred => Cannot be tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 2.5.9 affect-version: 3.0.7 affect-version: 4.0 RC 1 component: api / client library component: engine fix-version: 3.0.8 fix-version: 4.0.0 priority: major qa: cannot be tested type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvlad @firebird-automations