Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require exactly correct page size in DPB when creating database, reject wrong values [CORE6510] #6739

Open
firebird-automations opened this issue Mar 9, 2021 · 6 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @AlexPeshkoff

Depends on CORE6503

Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems.

Also would be good idea to detect (on client) garbage passed as page size which is currently treated as default page size.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Link: This issue depends on CORE6503 [ CORE6503 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Fix Version: 4.1 Initial [ 10961 ]

Fix Version: 5.0 Initial [ 10962 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: @mrotteveel

The rounding up for values smaller than 4096 is - I assume - for backwards compatibility with scripts that used 1024 or 2048. Also, keep in mind that this is documented behaviour (see https://firebirdsql.org/file/documentation/html/en/refdocs/fblangref25/firebird-25-language-reference.html#fblangref25-ddl-db-createdbopts), though that is mostly 'documenting how it actually works'.

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

description: Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems. => Currently FB accepts any numeric noise as valid page size, rounding it down (or up in case of small values) to the nearest correct page size. That behavior appera s to be very suspicious - looks like it may cause only problems.

Also would be good idea to detect (on client) garbage passed as page size which is currently treated as default page size.

@firebird-automations
Copy link
Collaborator Author

Commented by: @AlexPeshkoff

Yes Mark - I think keeping a rule that correct (power of 2) but too small values are treated as minimum available size is good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants