Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect included tomcrypt library from being overwritten by system package [CORE6516] #6745

Closed
firebird-automations opened this issue Mar 16, 2021 · 7 comments

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: Basil A. Sidorov (basid)

Tomcrypt library has a kind of "unstable" API. Default built of it does not include thread safety option - i.e. some global data structures are not protected by mutex. That's not good for us itself but what is worse - if firebird binary expects shared tomcrypt library built with thread safety ON but actually it was built (by third-party) with OFF different size of data structures in API calls causes segfault when working (for example) with PRNGs.
Therefore we include tomcrypt library in 'universal' binaries for linux but it can be easily overwritten with system package. Problematic library should be placed in a way that it will be always used by our binaries instead system one.

Commits: 1fbc1d0

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

Version: 4.0 RC 1 [ 10930 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

assignee: Alexander Peshkov [ alexpeshkoff ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

reporter: Alexander Peshkov [ alexpeshkoff ] => Basil A. Sidorov [ basid ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @AlexPeshkoff

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0.0 [ 10931 ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Resolved [ 5 ]

QA Status: No test => Cannot be tested

@firebird-automations
Copy link
Collaborator Author

Modified by: @pavel-zotov

status: Resolved [ 5 ] => Closed [ 6 ]

@firebird-automations
Copy link
Collaborator Author

Commented by: Basil A. Sidorov (basid)

Private libtomcrypt.so.1 moved from ${FIREBIRD_INSTALL}/lib/.tm to ${FIREBIRD_INSTALL}/lib.
No system-wide symlink on private libtmocrypt.
Currently installation checked on CentOS 7 (ncurses5, tommath0) and CentOS 8 (ncurses6, tommath1).
"Well done" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants