You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attached .7z files can illustrate the problem:
1) broken.fdb.7z - database which has some pages with arbitrary typed characters (near the beginning of file);
2) stack-trace-when-connect-to-broken-DB.7z and dump-when-connect-to-broken-DB.7z -- stack trace and dump when trying to connect to this DB (checked on LI-V4.0.0.2394)
Segfault was caused cause engine code absolutely trusted index root page, i.e. offsets pointing out of page were not checked. I've added minimum correctness check when reading such page. May be other pages also require that.
::: test details :::
Although test that reproduces FB crash does exist it was decided to stop any investigation on this issue because there is no point in checking a huge number of possible page corruptions (main reason: performance overkill on real production systems).
Letters from Vlad: 05-apr-2021 10:08, 13:47 (benchmark related to performance affect), from dimitr: 05-apr-2021 10:38. Final letter from Alex: 21-sep-2021 10:38.
Submitted by: @pavel-zotov
Attachments:
broken.fdb.7z
dump-when-connect-to-broken-DB.7z
stack-trace-when-connect-to-broken-DB.7z
Attached .7z files can illustrate the problem:
1) broken.fdb.7z - database which has some pages with arbitrary typed characters (near the beginning of file);
2) stack-trace-when-connect-to-broken-DB.7z and dump-when-connect-to-broken-DB.7z -- stack trace and dump when trying to connect to this DB (checked on LI-V4.0.0.2394)
Commits: f507390 d3ae9f4 98fadc5 81c563d 2573f14 3c99c75
====== Test Details ======
Test implemented but not yet committed to fbt-repo.
To be discussed further, after FB 4.x release.
The text was updated successfully, but these errors were encountered: