Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replication plugin can crash engine returning nullptr from startTransaction() method [CORE6539] #6766

Closed
firebird-automations opened this issue Apr 15, 2021 · 2 comments
Closed

Replication plugin can crash engine returning nullptr from startTransaction() method [CORE6539] #6766

firebird-automations opened this issue Apr 15, 2021 · 2 comments
Assignees
@dyemanov
Labels
affect-version: 4.0 RC 1 component: replication fix-version: 4.0.0 priority: major type: bug

Comments

@firebird-automations
Copy link
Collaborator

Submitted by: @aafemt

If a plugin return nullptr from startTransaction() and no error in status (for example it decided that this transaction must not be replicated for any valid reason) Firebird engine will crash trying to call transaction->tra_replicator->startSavepoint().

IMHO such situation must be handled gracefully by disabling replication of this transaction.

Commits: 3b3e51e
@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

assignee: Dmitry Yemanov [ dimitr ]

@firebird-automations
Copy link
Collaborator Author

Modified by: @dyemanov

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 4.0.0 [ 10931 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dyemanov dyemanov

Labels
affect-version: 4.0 RC 1 component: replication fix-version: 4.0.0 priority: major type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dyemanov @firebird-automations