Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async operations executed with cancelled CancellationToken [DNET1043] #954

Closed
firebird-automations opened this issue Apr 20, 2021 · 3 comments

Comments

@firebird-automations
Copy link

Submitted by: mace windu (mace_windu)

After update to recent provider version (8.0.1.0) which introduce async operations support, several of our tests, that check proper handling of cancelled token started to fail as they expect OperationCanceledException, but instead of it operation succedded (similar issue we recently reported for npgsql 5 release npgsql/npgsql#3379, so you can use sample code from there and replace npgsql types with fb types).

I have no list of all affected async operations, but at least ExecuteNonQueryAsync is not failing as it is expected.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: vNext [ 10982 ]

@tborgesvieira
Copy link

The problem apparently affected the functioning of Dapper too, after updating commands with QueryAsync are not respecting await

@cincuranet
Copy link
Member

Fixed via bee17df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants