Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error code management [DNET117] #128

Closed
firebird-automations opened this issue Sep 20, 2007 · 2 comments
Closed

Error code management [DNET117] #128

firebird-automations opened this issue Sep 20, 2007 · 2 comments

Comments

@firebird-automations
Copy link

Submitted by: Thomas Gaboriau (tgaboriau)

Assigned to: @carlosga

The ErrorCode property of FbException is not override. So it returns HRESULT E_FAIL ( 0x80004005 ) like it specifies in the documentation of ExternalException.

I think it could be good to override ErrorCode like this :

public override int ErrorCode
\{
  get
  \{
    if \( \( InnerException \!= null \) && \( InnerException is IscException \) \)
      return \( \(IscException\) InnerException \)\.ErrorCode;
    return base\.ErrorCode;
  \}
\}

Commits: 8e46b26

@firebird-automations
Copy link
Author

Commented by: @carlosga

Fixed in SVN thanks very much !!

@firebird-automations
Copy link
Author

Modified by: @carlosga

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant