Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GetOrdinal of FbDataReader [DNET119] #130

Closed
firebird-automations opened this issue Sep 22, 2007 · 8 comments
Closed

Improve GetOrdinal of FbDataReader [DNET119] #130

firebird-automations opened this issue Sep 22, 2007 · 8 comments

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Improve GetOrdinal of FbDataReader using sentinel trick. This can bring some performance kick.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

priority: Major [ 3 ] => Minor [ 4 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Component: http://ADO.NET Provider [ 10041 ]

@firebird-automations
Copy link
Author

Commented by: @carlosga

could you explain a bit what is that sentinel trick ?? please :)

@firebird-automations
Copy link
Author

Commented by: @cincuranet

Well, I didn't looked, whether I will be possible (and if we do some changes, we can loose performace on other side).

But the idea is, that when looping thru collection you need to do n checks (in worst case), whether you're at the end. But when you add the searched item to the end, you cak skip these checks and run until you find one (either the right (=it's not the last) or the added one (=it's the last)). So you save some boolean evaluations (especially, when the item is near end and collection is huge).

I'll have to do some performace test with this and without.

@firebird-automations
Copy link
Author

Modified by: @carlosga

Fix Version: 2.5.0 [ 10170 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

I've done some tests and operations during prepare bring the small speed up benefit back down.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: In Progress [ 3 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

Fix Version: 2.5.0 [ 10170 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants