New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GetOrdinal of FbDataReader [DNET119] #130
Comments
Modified by: @cincuranetpriority: Major [ 3 ] => Minor [ 4 ] |
Modified by: @cincuranetComponent: http://ADO.NET Provider [ 10041 ] |
Commented by: @carlosga could you explain a bit what is that sentinel trick ?? please :) |
Commented by: @cincuranet Well, I didn't looked, whether I will be possible (and if we do some changes, we can loose performace on other side). But the idea is, that when looping thru collection you need to do n checks (in worst case), whether you're at the end. But when you add the searched item to the end, you cak skip these checks and run until you find one (either the right (=it's not the last) or the added one (=it's the last)). So you save some boolean evaluations (especially, when the item is near end and collection is huge). I'll have to do some performace test with this and without. |
Modified by: @carlosgaFix Version: 2.5.0 [ 10170 ] |
Modified by: @cincuranetstatus: Open [ 1 ] => In Progress [ 3 ] |
Commented by: @cincuranet I've done some tests and operations during prepare bring the small speed up benefit back down. |
Modified by: @cincuranetstatus: In Progress [ 3 ] => Closed [ 6 ] resolution: Won't Fix [ 2 ] Fix Version: 2.5.0 [ 10170 ] => |
Submitted by: @cincuranet
Improve GetOrdinal of FbDataReader using sentinel trick. This can bring some performance kick.
The text was updated successfully, but these errors were encountered: