Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling AcceptChanges only for rows without errors when performing batch execution [DNET127] #139

Closed
firebird-automations opened this issue Nov 2, 2007 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: Pavel (chpasha)

I propose that when performing batch updates with the ContinueUpdateOnError property of the DataAdapter set to true, the AcceptChanges should be called only for rows with HasErrors=false (of course if AcceptDuringUpdate=true). It might be helpful for repeating Update operation after fixing errors in rows. For this reason erroneous rows should preserve their RowVerison

Consider following change in code:
instead of
if (this.AcceptChangesDuringUpdate)
{
row.AcceptChanges();
}
use
if (this.AcceptChangesDuringUpdate && !row.HasErrors)
{
row.AcceptChanges();
}

Commits: 04f7791

@firebird-automations
Copy link
Author

Modified by: @carlosga

Fix Version: 2.5.0 [ 10170 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

assignee: Carlos Guzman Alvarez [ carlosga_fb ] => Jiri Cincura [ cincura_net ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

Are you talking about the RowState, right (there's no RowVersion in DataRow)?

If so, I confirm, that SqlProvider doesn't change the RowState, if there's an error. I'll fix this ASAP.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

rev.422

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: In Progress [ 3 ] => Closed [ 6 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

security: Developers [ 10012 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants