You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
is it possible to implement an IDisposable pattern for FbRemoteEvent? There are a lot of small problems now. For instance:
if you pass an connection object to the FbRemoteEvent constructor there are two possibilities
1) you are as owner responsible for destroying this connection object - doesn't work for now, if you dispose connection, there is a socket exception, cause RemoteEvent still tries to read from already disposed stream
2) FbRemoteEvent should destroy it - there is no place in code, where FbRemoteEvent would manage connection dispose. As i understand, you cannot stop it from listening at all. the thread, that is reading responses from server is declared "background" and reads until owning window is destroyed (and causes bunch of ThreadAbortedException's)
to understand the problem, consider this test case
FbConnection conn1 = new FbConnection("");
conn1.Open();
revent = new FbRemoteEvent(conn1, new[] { "event" });
revent.RemoteEventCounts += revent_RemoteEventCounts;
revent.QueueEvents();
revent.CancelEvents();
revent.RemoteEventCounts -= revent_RemoteEventCounts;
revent.Connection = null;
//this will cause an socket exception
conn1.Dispose();
Is there any possibility to implement some Stop method (that causes stoppage of all socket/thread stuff) - in my opinion - CancelEvents might do this work. And it would be nice to know, that the same functionality (and also dispose of connection) would be done in Dispose method. We can still dispose connection on our own, but only if we can stop socket listening (and this must be clearly stated in docu).
Submitted by: Pavel (chpasha)
is it possible to implement an IDisposable pattern for FbRemoteEvent? There are a lot of small problems now. For instance:
if you pass an connection object to the FbRemoteEvent constructor there are two possibilities
1) you are as owner responsible for destroying this connection object - doesn't work for now, if you dispose connection, there is a socket exception, cause RemoteEvent still tries to read from already disposed stream
2) FbRemoteEvent should destroy it - there is no place in code, where FbRemoteEvent would manage connection dispose. As i understand, you cannot stop it from listening at all. the thread, that is reading responses from server is declared "background" and reads until owning window is destroyed (and causes bunch of ThreadAbortedException's)
to understand the problem, consider this test case
FbConnection conn1 = new FbConnection("");
conn1.Open();
revent = new FbRemoteEvent(conn1, new[] { "event" });
revent.RemoteEventCounts += revent_RemoteEventCounts;
revent.QueueEvents();
revent.CancelEvents();
revent.RemoteEventCounts -= revent_RemoteEventCounts;
revent.Connection = null;
//this will cause an socket exception
conn1.Dispose();
Is there any possibility to implement some Stop method (that causes stoppage of all socket/thread stuff) - in my opinion - CancelEvents might do this work. And it would be nice to know, that the same functionality (and also dispose of connection) would be done in Dispose method. We can still dispose connection on our own, but only if we can stop socket listening (and this must be clearly stated in docu).
Commits: 17b734e
The text was updated successfully, but these errors were encountered: