Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuppressFinalize in FirebirdSql.Data.Client.Gds.XdrStream [DNET187] #198

Closed
firebird-automations opened this issue Oct 11, 2008 · 5 comments

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Jira_subtask_inward DNET179

@firebird-automations
Copy link
Author

Commented by: @cincuranet

1. FirebirdSql.Data.Client.Gds.XdrStream

public XdrStream(Stream innerStream, Charset charset) : base()
{
this.buffer = new byte[8] { 0, 0, 0, 0, 0, 0, 0, 0 };
this.innerStream = innerStream;
this.charset = charset;

// !!! posible is no need
// GC.SuppressFinalize(innerStream);
}

if GC suppressed innerStream - the XdrStream is not disposed!!!

@firebird-automations
Copy link
Author

Modified by: @cincuranet

summary: ParameterBuffer posible has to Destructor to release stream field. => SuppressFinalize in FirebirdSql.Data.Client.Gds.XdrStream

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Version: 2.5.0 Alpha 2 [ 10240 ]

Version: 2.5.0 Alpha 1 [ 10230 ]

Version: 2.1.0 [ 10102 ]

Fix Version: 2.5.0 Alpha 3 [ 10261 ]

Fix Version: 2.5.0 [ 10170 ]

Component: http://ADO.NET Provider [ 10041 ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

The innerStream is later closed (and so resources are freed) in XdrStream.Close method.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Won't Fix [ 2 ]

Fix Version: 2.5.0 Alpha 3 [ 10261 ] =>

Fix Version: 2.5.0 [ 10170 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants