Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FbBatchExecution in method Execute() events improvements [DNET250] #259

Closed
firebird-automations opened this issue Jul 4, 2009 · 4 comments
Closed

FbBatchExecution in method Execute() events improvements [DNET250] #259

firebird-automations opened this issue Jul 4, 2009 · 4 comments
Assignees
@cincuranet
Labels
component: ado.net provider fix-version: 2.5.1 priority: major resolution: fixed/done type: task

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Jira_subtask_inward DNET247

class FbBatchExecution
in method Execute() sometimes for raising events used constructions like this
this.OnCommandExecuting(null);
...
this.OnCommandExecuted(null,...
Events raised by such calls are useless. It is not possible to know neither statement type nor statement text. Why not to pass sqlCommand?

Commits: 4038e84
@firebird-automations
Copy link
Author

Commented by: @cincuranet

Hi, I see this only on one place (where both null). Only places, where some null is:

Commit
null - OK, no command
statement - OK
Connect
null - OK, no command
statement - OK
CreateDatabase
null - OK, no command
statement - OK
Disconnect
(same as connect)
DropDatabase
null - OK, no command
null - KO, here we maybe can pass the string executed
Rollback
null - OK, no command
statement - OK

Do you thought about the DropDatabase or something else?

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

The DropDatabase method is modified. If somebody comes with other observation, we can reopen the issue.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.1 [ 10360 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cincuranet cincuranet

Labels
component: ado.net provider fix-version: 2.5.1 priority: major resolution: fixed/done type: task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cincuranet @firebird-automations