Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FbConnectionInternal public FbTransaction BeginTransaction methods issue [DNET251] #260

Closed
firebird-automations opened this issue Jul 4, 2009 · 8 comments

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Jira_subtask_inward DNET247

Votes: 2

class FbConnectionInternal
public FbTransaction BeginTransaction methods
as I think, if this.activeTransaction.BeginTransaction() call raises exception then activeTransaction should be disposed and nulled. if not - next time it will cause HasActiveTransaction to return true and InvalidOperationException("A transaction is currently active. Parallel transactions are not supported.") will be thrown. InvalidOperationException is not FbException and complecates exception handling in outer code.

Commits: 4ef2411 e083c5c

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: vNext [ 10833 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Commented by: Michal Catlos (rupulu)

In version 5.11.0.0 is this issue not fixed. _activeTransaction.BeginTransaction(options) throws FbException and not IscException, so DisposeTransaction() in catch block is never called.

@firebird-automations
Copy link
Author

Commented by: @cincuranet

Correct. The FbTransaction methods (being internal) should not handle the IscException and wrap it. It's a task for FbConnectionInternal, where the method is public. I'll change it later this week.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Resolved [ 5 ] => Reopened [ 4 ]

resolution: Fixed [ 1 ] =>

@firebird-automations
Copy link
Author

Commented by: @cincuranet

4ef2411

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Reopened [ 4 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 5.12.0.0 [ 10854 ]

Fix Version: 5.10.0.0 [ 10833 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants