Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening database with ANSI characters in filename using Firebird Embedded [DNET321] #332

Closed
firebird-automations opened this issue Jun 4, 2010 · 2 comments

Comments

@firebird-automations
Copy link

Submitted by: Robert Kindl (rkindl)

Votes: 1

In current version Firebird Embedded expects filenames to be in ANSI code page, but FB .NET provider encodes filename using charset specified in connection string.
This effectively prevents opening anything that is not base ASCII 128.

I suggest following patch in class FesDatabase

in method AttachDatabase and CreateDatabase replace following code:
byte[] databaseBuffer = this.Charset.GetBytes(database);
with:
byte[] databaseBuffer = System.Text.Encoding.Default.GetBytes(database);

In future when Firebird Embedded will support full unicode filenames this can be reverted or maybe implemented according to this future API change.

Commits: 9a5040b

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.5.3 [ 10380 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: 2.6 [ 10371 ]

Fix Version: 2.5.3 [ 10380 ] =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants