Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FbScript constructor changes [DNET322] #333

Closed
firebird-automations opened this issue Jun 5, 2010 · 1 comment
Closed

FbScript constructor changes [DNET322] #333

firebird-automations opened this issue Jun 5, 2010 · 1 comment

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

1. Only one constructor, taking string.
- the FbScript internally works with string so why bother with something else
2. Static method LoadFromFile returning instance
- following pattern in some classes in BCL
- it's better to state, we're actually reading the file now - in
ctor you don't know whether the file is read there or later when
needed
3. No ctor using TextReader.
- we have the string ctor now and this ctor was just simply reading
the whole content, so no benefit having it there, anybody can do it
yourself and know what (s)he is doing

Discussed in list in thread "RFC: FbScript changes".

Commits: 0e9772b

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.6 [ 10371 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants