You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Only one constructor, taking string.
- the FbScript internally works with string so why bother with something else
2. Static method LoadFromFile returning instance
- following pattern in some classes in BCL
- it's better to state, we're actually reading the file now - in
ctor you don't know whether the file is read there or later when
needed
3. No ctor using TextReader.
- we have the string ctor now and this ctor was just simply reading
the whole content, so no benefit having it there, anybody can do it
yourself and know what (s)he is doing
Discussed in list in thread "RFC: FbScript changes".
Submitted by: @cincuranet
1. Only one constructor, taking string.
- the FbScript internally works with string so why bother with something else
2. Static method LoadFromFile returning instance
- following pattern in some classes in BCL
- it's better to state, we're actually reading the file now - in
ctor you don't know whether the file is read there or later when
needed
3. No ctor using TextReader.
- we have the string ctor now and this ctor was just simply reading
the whole content, so no benefit having it there, anybody can do it
yourself and know what (s)he is doing
Discussed in list in thread "RFC: FbScript changes".
Commits: 0e9772b
The text was updated successfully, but these errors were encountered: