Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection pool cleanup timer is executed only once because timer is disposed in worker method [DNET408] #409

Closed
firebird-automations opened this issue Jan 30, 2012 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: Gerdus van Zyl (angelblaze)

Attachments:
FbConnectionPool.cs.patch
FbConnectionTests.cs.patch

Expected: after time specified in ConnectionLifeTime the connection is closed.
Reality: it is not.

Connection pool cleanup timer is executed only once because timer is disposed in worker method

@firebird-automations
Copy link
Author

Commented by: Gerdus van Zyl (angelblaze)

patches to fix connection pool cleanup and add unit test

@firebird-automations
Copy link
Author

Modified by: Gerdus van Zyl (angelblaze)

Attachment: FbConnectionPool.cs.patch [ 12090 ]

Attachment: FbConnectionTests.cs.patch [ 12091 ]

@firebird-automations
Copy link
Author

Commented by: Gerdus van Zyl (angelblaze)

moved patch to attachment

@firebird-automations
Copy link
Author

Modified by: Gerdus van Zyl (angelblaze)

description: Expected: after connection pool timeout the connection is closed.
Reality: it is not.

Connection pool cleanup timer is executed only once because timer is disposed in worker method

Patch to comment out the dispose:

Index: Data/FirebirdClient/FbConnectionPool.cs

--- Data/FirebirdClient/FbConnectionPool.cs (revision 53955)
+++ Data/FirebirdClient/FbConnectionPool.cs (working copy)
@@ -314,7 +314,7 @@
}
}

- pool.cleanupTimer.Dispose();
+ <//pool.cleanupTimer.Dispose>();
}
}

=>

Expected: after connection pool timeout the connection is closed.
Reality: it is not.

Connection pool cleanup timer is executed only once because timer is disposed in worker method

@firebird-automations
Copy link
Author

Modified by: Gerdus van Zyl (angelblaze)

description: Expected: after connection pool timeout the connection is closed.
Reality: it is not.

Connection pool cleanup timer is executed only once because timer is disposed in worker method

=>

Expected: after time specified in ConnectionLifeTime the connection is closed.
Reality: it is not.

Connection pool cleanup timer is executed only once because timer is disposed in worker method

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: 2.7.1 [ 10462 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

priority: Minor [ 4 ] => Major [ 3 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants