Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading error messages from a manifest resource fails on mono [DNET570] #186

Closed
firebird-automations opened this issue Oct 13, 2014 · 2 comments

Comments

@firebird-automations
Copy link

Submitted by: Michał Ziemski (r_o_o_k)

In method: FirebirdSql.Data.Common.IscException.CreateResourceSet(string resourceName)
the resourcestream is disposed before returning the resourceset. This doesn't work on mono (mono initializes the resourceset (reads the resourcestream) on
the first call to GetObject rather than in constructor).

Those resource set should be IMHO static properties initialized in the static constructor of IscException. In the current implementation at each iscexception a call is made to read the resource from disk, and a full resource dictionary is constructed. This is on aoverkill especially for server usages.

Commits: 7538cda

@firebird-automations
Copy link
Author

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: vNext [ 10661 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants