Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input buffer [DNET748] #690

Closed
firebird-automations opened this issue Mar 29, 2017 · 3 comments
Closed

Improve input buffer [DNET748] #690

firebird-automations opened this issue Mar 29, 2017 · 3 comments

Comments

@firebird-automations
Copy link

Submitted by: Gerdus van Zyl (angelblaze)

Relate to DNET740

cincuranet/FirebirdSql.Data.FirebirdClient#65

I looked at DNET740 (DNET740) and found the single threaded performance to be worse than it was.
Main performance killer was _inputBuffer.RemoveRange(0, data.Length);

Replaced the list with a class that keeps a list of the readbuffers and removes them when no longer needed.

Example performance on same data with 444528 rows
5.8: 11s
after this pull: 3.9s

Commits: 993517e

@firebird-automations
Copy link
Author

Modified by: @cincuranet

reporter: Jiri Cincura [ cincura_net ] => Gerdus van Zyl [ angelblaze ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Link: This issue relate to DNET740 [ DNET740 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Fix Version: vNext [ 10811 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants