Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big models overrun the hex literal limit when inserting into __MigrationHistory [DNET769] #709

Closed
firebird-automations opened this issue Jun 1, 2017 · 7 comments

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Is duplicated by DNET817

Instead of one big insert, multiple smaller updates might be a way out.

Commits: 407fee3

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Link: This issue is duplicated by DNET817 [ DNET817 ]

@firebird-automations
Copy link
Author

Commented by: Maxim Grishin (singthatsong)

Hello! As per Contributing file in your repository, I want to announce my intention to solve this one, because it`s kinda showstopper when using Firebird with Entity Framework.

I already have working prototype of migration, but I think it`s not perfect and requires some external help as I`m not that experienced when it comes to provider development.

I took an idea from description: instead of one big insert I'm splitting it into insert and subsequent updates (like UPDATE __MigrationHistory SET Model = Model || 'datachunk' WHERE MigrationId = 'id'). I'm doing it via modification of commandTree variable + creating new trees based on commandTree in FbMigrationSqlGenerator.cs > Generate(HistoryOperation) function and it works.

@firebird-automations
Copy link
Author

Commented by: @cincuranet

Feel free to create PR at https://github.com/cincuranet/FirebirdSql.Data.FirebirdClient and we can take it from there.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: 6.planned [ 10857 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: 6.4.0.0 [ 10884 ]

Fix Version: 6.planned [ 10857 ] =>

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

@firebird-automations
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants