Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing FbDataReader on broken connection throws IscException instead of FbException [DNET814] #749

Closed
firebird-automations opened this issue Mar 27, 2018 · 3 comments
Closed

Closing FbDataReader on broken connection throws IscException instead of FbException [DNET814] #749

firebird-automations opened this issue Mar 27, 2018 · 3 comments
Assignees
@cincuranet
Labels
component: ado.net provider fix-version: 6.4.0.0 priority: minor resolution: fixed/done type: bug

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Because it's trying to rollback implicit transaction (if any) and that, because of broken connection fails to do, and fails then in `finally` on `Dispose`.

There's probably more of these cases (FbCommand -> GdsStatement).

Commits: 0a5ef95
@firebird-automations
Copy link
Author

Commented by: @cincuranet

Probably FbTransactionL91 is a good place to do try-catch and wrap IscException into FbException.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: 6.4.0.0 [ 10884 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cincuranet cincuranet

Labels
component: ado.net provider fix-version: 6.4.0.0 priority: minor resolution: fixed/done type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cincuranet @firebird-automations