Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate option to remove weak references for FbCommands in connection to be able to properly track everything [DNET854] #786

Closed
firebird-automations opened this issue Oct 4, 2018 · 4 comments

Comments

@firebird-automations
Copy link

Submitted by: @cincuranet

Importantly how one FbCommand would play in prepared statements when used in multiple FbConnections.

Commits: 9f664a2

@firebird-automations
Copy link
Author

Modified by: @cincuranet

Fix Version: 6.4.0.0 [ 10884 ]

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => In Progress [ 3 ]

@firebird-automations
Copy link
Author

Commented by: @cincuranet

I think with the recent finalizers cleanup (DNET698) the weak reference doesn't make sense. There's no code that would release the statement in finalizer on server side, so it was just a collection. I'm changing it to regular reference and hence even if the command is no disposed (fail #⁠1) it's going to be disposed when the connection is closed (or returned to pool). This does not prevent shooting yourself into foot, but except for edge cases it's good enough.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: In Progress [ 3 ] => Resolved [ 5 ]

resolution: Fixed [ 1 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants