Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FbMigrationsSqlGenerator doesn't respect different code generation for firebird 2.5 and 3.0 [DNET901] #828

Closed
firebird-automations opened this issue Oct 1, 2019 · 2 comments

Comments

@firebird-automations
Copy link

Submitted by: Andreas Patock (apatock)

Generating the Tables via dotnet ef database update is working as expected if the Firebird-Server Version >= 3.0!
But running the same with Firebird-Server Version 2.5 leads to the following error:

D:\Source\CodeFirstTest\CodeFirstTest>dotnet ef database update -c CodeFirstTest.Model.FirebirdBloggingContext

Applying migration '20191001083549_Initial'.
Failed executing DbCommand (23ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
CREATE TABLE "Blogs" (
"BlogId" INTEGER GENERATED BY DEFAULT AS IDENTITY NOT NULL,
"Name" BLOB SUB_TYPE TEXT,
CONSTRAINT "PK_Blogs" PRIMARY KEY ("BlogId")
);
FirebirdSql.Data.FirebirdClient.FbException (0x80004005): Dynamic SQL Error
SQL error code = -104
Token unknown - line 2, column 32
BY ---> Dynamic SQL Error
SQL error code = -104
Token unknown - line 2, column 32
BY
at FirebirdSql.Data.FirebirdClient.FbCommand.ExecuteNonQuery()
at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.Execute(IRelationalConnection connection, DbCommandMethod executeMethod, IReadOnlyDictionary`2 parameterValues)
at Microsoft.EntityFrameworkCore.Storage.Internal.RelationalCommand.ExecuteNonQuery(IRelationalConnection connection, IReadOnlyDictionary`2 parameterValues)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationCommandExecutor.ExecuteNonQuery(IEnumerable`1 migrationCommands, IRelationalConnection connection)
at Microsoft.EntityFrameworkCore.Migrations.Internal.Migrator.Migrate(String targetMigration)
at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.UpdateDatabase(String targetMigration, String contextType)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Dynamic SQL Error
SQL error code = -104
Token unknown - line 2, column 32
BY

@firebird-automations
Copy link
Author

Commented by: @cincuranet

That's expected. FB3.0 and up is only considered and supported by EFCore provider. And I currently don't plan adding support for 2.5, mostly because of lack of resources.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants