Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not providing DataSource to connection now causes error [DNET912] #839

Closed
firebird-automations opened this issue Nov 1, 2019 · 2 comments

Comments

@firebird-automations
Copy link

Submitted by: Greg Cobb (fyndor)

I have some code that broke after updating to 7.1.1 from 6.5. I have a program, a custom installer application we wrote, that is only ever run on the same computer where Firebird is installed. Previously because the application already had verified that it was being run on the server, I didn't bother to specify that the DataSource property on FbConnectionStringBuilder should be set to localhost. After updating to 7.1.1, this lack of providing the DataSource explicitly broke our application. I am sorry, but I have not reverted back to 6.5 to prove whether the FbConnectionStringBuilder is the one forgetting to specify that the DataSource should be localhost by default or whether it is instead the FbConnection class that can no longer handle not being provided a DataSource.

Error Message:

An invalid connection string argument has been supplied or a required connection string argument has not been supplied.

It is my opinion that this probably should be something where you probably want to keep applications that did not provide the DataSource from breaking when they update to the latest http://ADO.NET driver. I know that in most scenarios you will want to provide a DataSource, but localhost seems to have been the default up until now and that is probably a pretty safe bet if one was not provided.

@firebird-automations
Copy link
Author

Commented by: @cincuranet

You should really read release notes (at least when updating across major versions), DNET897 in particular.

@firebird-automations
Copy link
Author

Modified by: @cincuranet

status: Open [ 1 ] => Closed [ 6 ]

resolution: Won't Fix [ 2 ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants